gtfs.zone/coloring-book

feat: basic brouter shapes handling #124

Merged

maxtkc merged 8 commits from 120-shapes-brouter into main

2026-05-11 22:34:57 +00:00

maxtkc commented

2026-05-11 22:34:43 +00:00

Owner

Closes #120

Closes #120

maxtkc self-assigned this

2026-05-11 22:34:43 +00:00

maxtkc added 8 commits

2026-05-11 22:34:43 +00:00

feat: add GPX parser utility for shapes import ad5338b9fd

feat: add ShapesManager modal with GPX import/replace/delete 66f5ac705c

feat: add brouter deep-link to timetable direction tabs 187f82d380

feat: render shape_id as dropdown in timetable trip properties bf040db6c5

feat: per-trip brouter links, upload icon, click-away modals cb0b512b81

fix: re-assign trips to shape geometry after GPX replace 35d2df15ff

When a shape is replaced (delete + insert), handleShapeRemoved removes
the shape's features from routeFeatures. The subsequent insert call to
invalidateShape sets the new coords in shapeIndex but finds no matching
features to update in-place. Detect this case (anyUpdated === false) and
call invalidateTrip('insert') for each trip referencing the shape so
they are re-bucketed with the new shape geometry without a page reload.

fix: use update op when re-assigning trips to replaced shape 0e0bc13294

When anyUpdated is false (shape deleted then re-inserted via GPX replace),
calling invalidateTrip with 'insert' skips the bucket-removal step, leaving
the trip in the stop-seq fallback bucket created by handleShapeRemoved.
Both a stop-seq feature and a shape feature then exist in routeFeatures,
with the stop-seq drawn on top and the shape invisible.

Using 'update' instead causes invalidateTrip to first remove the trip from
its old stop-seq bucket (via tripToFeatureKey → removeTripFromBucket) before
adding it to the new shape bucket, so only the shape geometry is rendered.

refactor: simplify ShapesManager types and file picker 233c6ec64c

maxtkc merged commit 037a45311a into main

2026-05-11 22:34:57 +00:00

maxtkc deleted branch 120-shapes-brouter

2026-05-11 22:34:57 +00:00

maxtkc referenced this pull request from a commit

2026-05-11 22:34:57 +00:00

Merge pull request 'feat: basic brouter shapes handling' (#124) from 120-shapes-brouter into main

Sign in to join this conversation.

No reviewers

No labels

Compat/Breaking

Kind/Documentation

Kind/Enhancement

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

gtfs.zone/coloring-book!124

No description provided.