gtfs.zone/coloring-book
1
0
Fork 0
Code Issues 18 Pull requests Projects 1 Releases Packages Wiki Activity Actions

Always show map + feed info #53

Merged
maxtkc merged 9 commits from 42-show-map-and-feed-info into main 2026-03-31 08:23:44 +00:00
Conversation 0 Commits 9 Files changed 9 +86 -169
maxtkc commented 2026-03-31 08:19:51 +00:00
Owner
Copy link

Closes #42

Closes #42
Two bugs caused feed_info edits to be lost on refresh:

1. Array mismatch: gtfsData[filename].data and the flat array passed to
   setupVirtual were two different [] instances. persistDirtyBlobs reads
   gtfsData.data, but the virtual table mutates its own flat array, so
   blob saves always saw an empty array and were skipped.

2. No initial row: the virtual table update handler silently returns
   when byId has no entry for the key. With an empty feed_info table,
   every field edit was a no-op in memory, and patch replay on reload
   also silently failed — leaving hasExistingRows=false and causing
   initializeEmpty to call clearDatabase, destroying the patches.

Fix: share the same array reference between gtfsData.data and setupVirtual,
seed feed_info with an all-empty-string row (schema-keyed so CSV headers
are correct), and flush the seed blob to IDB immediately so patch replay
always has a row to land on even after a quick refresh.
maxtkc merged commit 100efacca3 into main 2026-03-31 08:23:44 +00:00
maxtkc deleted branch 42-show-map-and-feed-info 2026-03-31 08:23:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
  
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
gtfs.zone/coloring-book!53
No description provided.